8000 Run time error when trying the example from billstclair/elm-sortable-table. · Issue #160 · elm/virtual-dom · GitHub
[go: up one dir, main page]

Skip to content

Run time error when trying the example from billstclair/elm-sortable-table. #160

Open

Description

@digitalsatori

I encountered runtime error when I test the ‘tripl planner’ example in billstclair/elm-sortable-table.
The “TypeError: Argument 1 (‘node’) to Node.appendChild must be an instance of Node” occurred, when clicking on ‘Rating’ column after clicking on ‘Price’ column. The gif is attached.

Tested in Safari, google chrome and firefox with extension disable, the same error.

sortable-table

Activity

  1. boianr commented on Mar 6, 2019

    @boianr

    I managed to reproduce this locally. I can't figure why this happens yet, but I narrowed it down to Html.Keyed.node.
    Changing line https://github.com/billstclair/elm-sortable-table/blob/b9c4f87eb55b7f96b9f0f5ec717617ea0f08bad6/src/Table.elm#L466 to use Html.node instead of Keyed.node fixes the issue.

    This should probably be addressed elsewhere.

  2. digitalsatori commented on Mar 10, 2019

    @digitalsatori
    Author

    @boianr Thank you for taking time to confirm the issue and narrow it down to the problematic code.
    I'm guessing that the issue may not even belong here. Maybe https://github.com/elm/virtual-dom is a more proper place.

  3. transferred this issue fromelm/coreon Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0