You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Run time error when trying the example from billstclair/elm-sortable-table. #160
I encountered runtime error when I test the ‘tripl planner’ example in billstclair/elm-sortable-table.
The “TypeError: Argument 1 (‘node’) to Node.appendChild must be an instance of Node” occurred, when clicking on ‘Rating’ column after clicking on ‘Price’ column. The gif is attached.
Tested in Safari, google chrome and firefox with extension disable, the same error.
@boianr Thank you for taking time to confirm the issue and narrow it down to the problematic code.
I'm guessing that the issue may not even belong here. Maybe https://github.com/elm/virtual-dom is a more proper place.
Activity
boianr commentedon Mar 6, 2019
I managed to reproduce this locally. I can't figure why this happens yet, but I narrowed it down to
Html.Keyed.node.Changing line https://github.com/billstclair/elm-sortable-table/blob/b9c4f87eb55b7f96b9f0f5ec717617ea0f08bad6/src/Table.elm#L466 to use
Html.nodeinstead ofKeyed.nodefixes the issue.This should probably be addressed elsewhere.
digitalsatori commentedon Mar 10, 2019
@boianr Thank you for taking time to confirm the issue and narrow it down to the problematic code.
I'm guessing that the issue may not even belong here. Maybe https://github.com/elm/virtual-dom is a more proper place.