8000 Cleanup Linux comments · Issue #114 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]

Skip to content

Cleanup Linux comments #114

Open
Open

Description

@Jake-Shadle

A lot of comments in the linux implementation are ripped directly from the Breakpad C++ code and don't take into account changes in the API nor take advantage of Rust documentation features, eg.

/// Copies content of |length| bytes from a given process |child|,
/// starting from |src|, into |dest|. This method uses ptrace to extract
/// the content from the target process. Always returns true.
pub fn copy_from_process(
child: Pid,
src: *mut c_void,
num_of_bytes: usize,
) -> Result<Vec<u8>, DumperError> {

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0