8000 The Linux minidump writer is mishandling EINTR when waiting for a thread to stop after having attached to it · Issue #39 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]

Skip to content

The Linux minidump writer is mishandling EINTR when waiting for a thread to stop after having attached to it #39

Closed

Description

@gabrielesvelto

This is something I noticed reading the code, see the loop here. We've just called ptrace(PTRACE_ATTACH, pid) on a given thread and we need to waitpid() for it. If we get an error and errno is EINTR (that is we received a signal and handled it) we're supposed to wait again, if we get any other error we should detach from the thread and return. It seems to me that we're doing the opposite (i.e. we detach and return on EINTR and try again for other values of errno).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0