Repository navigation
process-backend: don't panic on transport failure - #248
Merged
Merged
Conversation
Panics should be avoided, as crashing the crash helper is not particularly helpful (or even actively harmful on Android). This will likely result in crash reports with a few similar looking poison errors in their SoftError streams as various systems attempt to get their data, but that's preferrable to no report at all.
gabrielesvelto
approved these changes
Oct 26, 2026
Contributor
There was a problem hiding this comment.
LGTM, we learned the hard way that panics on Android are visible to the user even in invisible processes so this is the way to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panics should be avoided, as crashing the crash helper is not particularly helpful (or even actively harmful on Android).
This will likely result in crash reports with a few similar looking poison errors in their SoftError streams as various systems attempt to get their data, but that's preferrable to no report at all.