Repository navigation
Can't reset TCLink to zero loss and delay #881
Description
This optimization prevents zeroing loss or delay link parameters after non-zero period because "not 0 = True" in Python:
Lines 352 to 354 in e203808
It should be compared to None or running value instead.
Activity
Fix bug in if condition, see mininet#881
cheriimoya commentedon Feb 2, 2022
you are right
lantz commentedon Apr 1, 2022
I believe the intent was to not add an unnecessary queuing discipline.
Is there a workaround if you set the loss to
0%?Fix bug in if condition, see mininet#881
janev94 commentedon Nov 18, 2022
addLink currently by default makes loss to 0%. This is not an issue in the current build at least @lantz .
lantz commentedon Nov 19, 2022
@cheriimoya
Is setting the loss to
0%a reasonable workaround?greenbigfrog commentedon Apr 1, 2025
Setting loss via a str doesn't work in mn
2.3.1b4.What kind of works as a semi workaround for me for now, is setting it to a tiny tiny float value. Although being able to go back to 0% loss would be preferred.
janev94 commentedon Apr 1, 2025
As I said above, when you do not provide value for loss for
addLinkit does not add loss, by default. If you want to apply loss dynamically you should use the patch that @cheriimoya quoted in the thread.greenbigfrog commentedon Apr 1, 2025
Alright, thanks.
I understood this issue to be purely about resetting link loss, which implies dynamically changing loss back to 0.
I'll use the fix in the PR.