Repository navigation
STY: Apply ruff/flake8-comprehensions rules (C4) - #3680
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3680 +/- ##
=======================================
Coverage 70.86% 70.87%
=======================================
Files 1276 1276
Lines 59229 59233 +4
Branches 9812 9796 -16
=======================================
+ Hits 41975 41979 +4
- Misses 16079 16084 +5
+ Partials 1175 1170 -5 ☔ View full report in Codecov by Sentry. |
DimitriPapadopoulos
force-pushed
the
C4
branch
from
September 22, 2024 13:38
8b4c8ef to
f81392c
Compare
DimitriPapadopoulos
force-pushed
the
C4
branch
2 times, most recently
from
October 6, 2024 13:33
215576c to
0fdc45e
Compare
effigies
reviewed
Oct 6, 2024
Member
There was a problem hiding this comment.
Bunch of comments. Hopefully not overlapping with other rules...
DimitriPapadopoulos
force-pushed
the
C4
branch
2 times, most recently
from
October 6, 2024 15:46
565ca25 to
2685c02
Compare
effigies
approved these changes
Oct 6, 2024
Member
There was a problem hiding this comment.
Thanks! One final suggestion.
C400 Unnecessary generator (rewrite as a `list` comprehension)
C409 Unnecessary `list` literal passed to `tuple()` (rewrite as a `tuple` literal)
C414 Unnecessary `list` call
C416 Unnecessary `list` comprehension (rewrite using `list()`)
C419 Unnecessary list comprehension
DimitriPapadopoulos
force-pushed
the
C4
branch
from
October 6, 2024 15:49
2685c02 to
679123a
Compare
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
DimitriPapadopoulos
force-pushed
the
C4
branch
from
October 6, 2024 15:53
679123a to
1747356
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply flake8-comprehensions (C4) rules, except: