Repository navigation
feature: devcontainer configuration for easier Ginkgo contribution - #1663
Merged
Merged
Conversation
Signed-off-by: thediveo <thediveo@gmx.eu>
Signed-off-by: thediveo <thediveo@gmx.eu>
Owner
|
oh man, i'm an old school fart when it comes to fancy dev container tooling. happy to pull this in if it makes other people's lives easier but might need help maintaining it and fielding issues if/when they come up. |
Contributor
Author
|
Using devcontainers for (only) one and a half years I'm considering myself still kind of a late-comer, with the benefit of a more mature technology. For me, it simplifies working with different projects and the tools needed. I always struggle with Ginko's and Gomega's Ruby/Rails/Jeckyll setup and this gives me a quickly reproducable setup. There are some startups with devcontainer tooling that doesn't work; devpod by loft labs doesn't work, they wanted to argue about what (transient) dependencies are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an optional development container configuration to the Ginkgo repository:
ginkgotestruns the same Ginkgo-based full testing as the test workflow does.serve-docsrunsbundle exec jekyll serveinside thedocs/directory, serving on local container port 4000.To use with VSCode and the "dev containers" extension installed: command => "Dev Containers: Open Folder in Container...". This should automatically pick up the devcontainer configuration from
.devcontainer/devcontainer.jsonand build the dev container according to spec (which will initially take a while); afterwards, the dev container is started and its configuration completed, wait for the bundler installation to finish.