Repository navigation
Clarify sanitizer requirements in CLI help - #1683
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1656.
Keep the short descriptions for
--asanand--msan, but refer supported platforms and compiler requirements togo help build. This follows the installed Go version instead of duplicating another platform list that can go stale.Only the two usage strings change. The new integration cases invoke the real
ginkgo help buildcommand and check both sanitizer descriptions; both cases fail with the original text. The abbreviatedrunandwatchhelp remains unchanged.Validation
makepasses.go vet ./...passes on both versions.go.modandgo.sumunchanged.runandwatchhelp is byte-identical.