Repository navigation
Delegate to upstream Applicative[Signal] - #229
Merged
Merged
Conversation
armanbilge
marked this pull request as draft
April 13, 2023 00:34
Owner
Author
|
Actually this should wait for the next FS2 release, otherwise we are introducing bugs ... 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we don't have to replicate fixes like typelevel/fs2#3206.
Also instead of
apwe overrideproductandmap2instead, since it turns outFlatMapwas overriding those withflatMapbased implementations. I think they are the most commonly used ones and there is a performance win sinceflatMapinvolves tearing down and restarting the inner signal.