8000 Empty value in excel is converted into 0 · Issue #15 · dominictarr/excel-stream · GitHub
[go: up one dir, main page]
Skip to content

Empty value in excel is converted into 0 #15

New issue
New issue
Open
Open
Empty value in excel is converted into 0#15

Description

@sc-brikis
sc-brikis
opened on May 16, 2016

Every empty value in excel is converted to 0 due to fact that:

isNaN('') => false

and line 41: _data[k.trim()] = isNaN(value) ? value : +value

makes empty record to 0.

I suggest following to check if value is number or not:

(isNaN(value) || value === '') ? value : +value;

you can find working sample here.

Activity

  1. kishorsharma
    added a commit that references this issue on May 16, 2016

    Adding empty string check. dominictarr#15

    ed5f521

  2. raapperez commented on Oct 31, 2016

    @raapperez
    raapperez
    on Oct 31, 2016

    Is there a solution for this?

  3. lteacher
    added a commit that references this issue on Mar 29, 2017

    Fix some issues

    b68a1f1
  4. lteacher
    added a commit that references this issue on Apr 13, 2017

    Fixes a number of issues:

    d30ee44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions
      0