Repository navigation
fix(effects): preserve uncertainty after adapter errors - #208
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An effect adapter can apply an action and then lose its response. The coordinator previously recorded
FAILEDfor that error, causing restart reconciliation to skip an outcome that was still unknown.Keep the durable and returned obligation
ATTEMPTEDand return explicit uncertainty with the original error. Read-only reconciliation can establish success or failure using destination evidence, without resending. Update the operations guide and threat model to describe this behavior and the preservation of historical terminal records.Validation: four regressions exercise real coordinator admission and SQLite close/reopen for transport errors, partial evidence with an error, caller cancellation, and an adapter deadline. Each fails against the original implementation and passes with the fix. They cover discovery, unavailable reconciliation, evidence-based terminal outcomes, and one dispatch only. Build, vet, lint, module consistency, the full unit suite, architecture boundaries, AIMS document checks, affected-package race tests, and vulnerability scanning passed in a canonical Linux checkout. A separate bounded source audit found no additional findings.
Production effect-writing adapters remain unavailable. This fixes the composable coordinator contract; it does not complete the broader containment work in #178.
Closes #207.