8000 ci: skip code checks for documentation changes by dominicnunez · Pull Request #200 · dominicnunez/agentos · GitHub
[go: up one dir, main page]

Skip to content

ci: skip code checks for documentation changes - #200

Merged
dominicnunez merged 4 commits into
mainfrom
ci/docs-checks
Sep 12, 2026
Merged

dominicnunez merged 4 commits into
mainfrom
ci/docs-checks

Conversation

@dominicnunez
@dominicnunez dominicnunez commented Sep 12, 2026 •
Copy link
Copy Markdown
Owner

Ordinary documentation changes currently rebuild and test the application and release artifacts. This change skips those code steps for a conservative document allowlist while retaining document checks and all required job results.

A shared classifier reads the complete local Git diff, including deletions and mode changes. Code, schemas, scripts, workflows, dependencies, configuration, unknown paths, and uncertain history keep full checks. Tags and manual runs also keep full checks. The required release job explicitly fails when its frontend prerequisite fails or is cancelled. Existing document-history verification and branch protection are unchanged.

Validation: 89 Python classifier/document tests passed; both workflows passed actionlint. Real Git cases cover tested PR merge trees, new branches, missing revisions, renamed code, executable/symlink documents, UTF-8 filename validation, malformed event data, and more than 3,000 changed files. An earlier documentation-only push verified code steps were skipped while document checks passed. The complete PR and final review-fix push contain code and therefore run full verification. Test repositories disable detached maintenance; 100 cleanup repetitions passed with Git tracing confirming no automatic maintenance children.

The threat model and development documentation describe the resulting scope. Security review is required after a clean general review.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Sep 12, 2026 •
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-12T13:10:10.967204Z 11364d0 New commits
🔒 Security Review ✅ Completed 2026-09-12T13:24:54.855786Z 11364d0 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78a1463dd4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/ci_scope.py Resolved
@dominicnunez
Copy link
Copy Markdown
Owner Author

@codex security review

@chatgpt-codex-connector
Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 11364d04b3

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@dominicnunez
dominicnunez merged commit 027e9fd into main Sep 12, 2026
5 checks passed
@dominicnunez
dominicnunez deleted the ci/docs-checks branch September 12, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0