Repository navigation
feat(runtime): retain model stop evidence - #216
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
Adaptive planning and model-based intent normalization could remain blocked after shutdown or a security hold without durable stop evidence. This change retains ownership through model return and durable result admission, releases callers after a bounded acknowledgement wait, and records the exact manifest-bound stop request, uncertainty, and eventual local outcome. Returned usage is committed atomically with confirmation; stopped work cannot publish ordinary plans or drafts.
The ledger distinguishes calls that never started from callbacks that actually returned, preserves already committed decisions, and validates retry evidence before a new attempt. Live admission, filtered readers, replay, projection rebuild, and recovery reject contradictory or late evidence and results that omit their manifested execution identity. Genuine unmanifested legacy results remain supported.
Shutdown attempts a bounded drain. A timeout reports failure and retains uncertainty and conservative accounting; local return does not prove remote termination. Suspended-task resumption and the remaining coordination/output/effect and cancellation-timeline audit stay under #178.
Validation
Refs #178