Repository navigation
Merged
Conversation
aligator
requested changes
Jul 5, 2021
Collaborator
There was a problem hiding this comment.
Hi, thanks for the PR.
I have just a small change request.
Comment on lines
58
to
63
| if !confirmed { | ||
| if !askForConfirmation() { | ||
| out.Info("Project NOT deleted.") | ||
| return | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Wouldn't that be a bit nicer code? Avoid stacked ifs if possible and feasible.
Suggested change
| if !confirmed { | |
| if !askForConfirmation() { | |
| out.Info("Project NOT deleted.") | |
| return | |
| } | |
| } | |
| if !confirmed && !askForConfirmation() { | |
| out.Info("Project NOT deleted.") | |
| return | |
| } |
Contributor
Author
There was a problem hiding this comment.
Yes that makes sense. In fact, I was merely mindlessly copying the if-logic from the deleteRecordCommand and did not even think that there was a cleaner way to do it. I will submit another commit with an edit to deleteRecordCommand as well.
Contributor
Author
There was a problem hiding this comment.
While discussing code style, I also refactored the if options.Revert checks to remove the else statement for cleaner code, following the advice from https://medium.com/@matryer/line-of-sight-in-code-186dd7cdea88.
Please have a look at the new commit and let me know if that's alright!
dominikbraun
approved these changes
Jul 5, 2021
Owner
There was a problem hiding this comment.
Nice! The best else-blocks are the else-blocks that don't exist 😎
This fix will be included in the next patch release later today.
aligator
approved these changes
Jul 5, 2021
Owner
|
This PR is included in timetrace v0.11.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses:
--reverthelp messages, changeit'stoits.--yesflag indeleteProjectCommand. This PR fixes that.