Repository navigation
Conversation
kevin9327
requested review from
miloschwartz and
oschwartz10612
as code owners
November 10, 2026 21:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
AI Disclosure
This change was prepared with AI assistance: code, test and description. It was reviewed and tested before submission.
Description
The target host field splits a pasted
scheme://host:portinto method, host and port, but it only recognizes the scheme in lowercase. TypingHttps://example.com:8443(phone keyboards capitalize the first letter) skips the scheme check, soparseHostTargetprependshttp://and parseshttp://Https://example.com:8443. The URL parser then readshttpsas the hostname and finds no port, so the target is saved with hosthttpsand port80.URL schemes are case-insensitive, so this adds the
iflag to the scheme pattern and shares it betweenparseHostTargetand the host field'shasProtocolcheck, so both agree. The protocol returned is already lowercase because it comes fromURL.protocol.How to test?
npx tsx src/lib/parseHostTarget.test.ts: the new test covers lowercase, scheme-less and capitalized (Https,HTTP,H2C) inputs. The capitalized cases fail ondev(hosthttps, port80) and pass with this change.