Repository navigation
compat: Stop forwarding the parent's assets option - #1294
Merged
Merged
Conversation
The override check missed the store's -D:assets spelling, so the parent's assets=auto replaced the sub-build's assets=installed. Hold assets back with the other options the sub-build sets itself, and drop the separate override list.
The check for -Dfrida_version never matched the store's -D:frida_version spelling. Append the version the parent resolved unconditionally.
oleavr
force-pushed
the
compat-root-options
branch
from
November 12, 2026 09:11
f1241eb to
61cd524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meson's option store spells root project options with a leading
:, so theparent's
-D:assets=autoslipped pastOVERRIDDEN_COMPAT_OPTIONSandreplaced the sub-build's
-Dassets=installed. In builds with installedassets, such as
--enable-shared --without-prebuilds=sdkon macOS, the arm64esub-build then failed with "At least one agent must be provided", as its
frida-server wanted an embedded agent.
option_should_be_forwarded()already holds back every other option thesub-build sets itself, so hold
assetsback there too and drop the separateoverride list.
The same spelling meant the
-Dfrida_version=check never matched; append theresolved version unconditionally instead.