Repository navigation
compat: Forward top-level builtin options - #1295
Merged
Merged
Conversation
Meson keys top-level builtin options with subproject None, while top-level project options use "". We only matched the latter, so builtins such as strip never reached compat builds, which resulted in e.g. a stripped arm64 gadget slice despite --enable-symbols.
oleavr
force-pushed
the
compat-forward-builtin-options
branch
from
November 12, 2026 13:42
83f6ed7 to
d62dce1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meson keys top-level builtin options with subproject None, while top-level project options use "". We only matched the latter, so builtins such as strip never reached compat builds, which resulted in e.g. a stripped arm64 gadget slice despite --enable-symbols.