Repository navigation
qnx: Fix a couple quirks - #1290
Merged
Merged
Conversation
The writer assumed the code would run where it was generated, so calls to libc functions within BL range of the local buffer were encoded with offsets that are wrong in the target process.
On QNX 6.5 ARM, libc's _exit() is a lone BL into __exit(), and the Interceptor cannot tell where it ends. Look up the symbol sizes and pass them as redirect_space_hint so the redirect stays within the function.
Member
|
Thanks! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref frida/frida#3818. Bundled PR for convenience; let me know if you'd rather they be split out. Comments/explanations are in the PR. Will require frida/frida-gum/#1211 to be merged first for
exit-monitorchanges to apply.On that note, I'm not honestly particularly happy with this way of fixing exit-monitor; if you have any better ideas, I'd be very open to using that instead.
LLMs were used in the creation of this PR, but code and logic were reviewed and tested on both an x86 VM and a physical ARM device.