Repository navigation
package-manager: Catch Efni errors too - #1293
Merged
Merged
Conversation
Catch the Efni.Error that FS throws for a missing package.json in the already-installed probe, which otherwise fails every fresh install. Wrap Efni errors from tarball extraction as well.
The calls they guard only throw Frida.Error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Efni split,
FS.read_all_bytes()throwsEfni.Error, which thealready-installed probe's
catch (Error e)let escape. Every install into afresh project failed with "Error opening file …/package.json: No such file or
directory" before downloading anything. Tarball extraction errors from Efni
also skipped the PROTOCOL wrapping.
Also drop the
catch (Efni.Error e)clauses the split added around calls thatonly throw
Frida.Error, which valac reports as unreachable.