Repository navigation
refactor(mcp): convert tool results with pi-mcp's toLlmContent - #161
Merged
Merged
Conversation
mikan converted MCP content blocks to model content itself. pi-mcp's toLlmContent does the same and passes an image embedded as a resource through as an image, which mikan replaced with a placeholder line. Only the empty-result placeholder stays, because a provider can reject a tool result with no content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP tool results are converted to model content with pi-mcp's
toLlmContentinstead of mikan's own block conversion (-90 lines). mikan keeps only the(empty result)placeholder, because a provider can reject a tool result with no content; truncation, digest, and spill are unchanged.Eval (MCP stdio server returning each shape, read through
loadMcpToolsas the model sees it)[Resource: … binary content omitted][Resource: uri]+ text{"a":1}{"a":1}(empty result)(empty result)Verification