Repository navigation
feat(sandbox): name the mikan-managed sandbox oci:<image> - #172
Merged
Merged
Conversation
The mode was named after its argument, image:, which also describes container:, and its docs still called it Docker. It runs one container per office from an OCI image on nerdctl, Podman, or Docker, so the sandbox spec is now oci:<image> and the internal type is "oci". image:<image> keeps working and logs a deprecation warning until the next major release. Container names, vault keys, and the managed- container labels do not include the type, so existing containers are reused. The docs page moves to /sandbox/oci/, with redirects from the old URLs.
Deploying mikan with
|
| Latest commit: |
ac09cd4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e1c337c.mikan-1wv.pages.dev |
| Branch Preview URL: | https://feat-oci-sandbox-name.mikan-1wv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
為什麼要改
image:<image>是用「參數」來命名，不是用「這個模式是什麼」：container:<name>其實也是從 image 跑起來的，兩個名字分不出差別。文件也還把它寫成「Docker」。這個模式真正的內容是：mikan 為每個 office 從 OCI image 建立並管理一個 container，nerdctl、Podman、Docker 都能跑。所以改名為oci:<image>。改了什麼
--sandbox=oci:<image>。內部型別"image"改為"oci"，ImageSandboxConfig改為OciSandboxConfig。image:<image>照樣能用，啟動時印出棄用警告，下一個主要版本移除：mikan.sandbox=image刻意不改。所以升級後會沿用既有 container，不會重建，也不需要 migration。mikan onboard和 PM2 ecosystem 範本改為產生oci:。/sandbox/image/頁面改為/sandbox/oci/，舊網址會轉址過去驗證
oci:ubuntu:24.04解析成{type:"oci"}，不印警告image:ubuntu:24.04解析成同樣的設定並印出棄用警告mikan migrate --dry-run）：image:印出警告、oci:不印、oci:不帶 image 時報錯--sandbox oci:…，引擎 Docker）Release note
--sandbox=image:<image>改名為--sandbox=oci:<image>。舊寫法仍可使用並會印出棄用警告，下一個主要版本移除。既有 container 和 vault 不受影響。請把 PM2 ecosystem 或啟動腳本裡的image:改成oci:。