Repository navigation
fix(tools): give codemode scripts no default deadline, as in Pi - #184
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mikan gave every codemode script a 60-second deadline unless the script set
timeout_ms. pi-codemode leaves the deadline to its caller, and Pi's own codemode (coding agent and pi-durable 1.2) uses no deadline by default. In production a script that calledjev_browserto fill a form was cut off at 59.9 s ("Execution timed out after 60000 ms").What
timeout_ms, the sandbox getsNumber.POSITIVE_INFINITY, as Pi passes. A script's owntimeout_msstill applies.Consequence: a stuck script in an ordinary conversation runs until the conversation is stopped (Stop aborts the sandbox through the run's abort signal). Event runs keep their run budget. Ordinary runs have no duration budget by default.
Verification
Infinitywithouttimeout_msand 1234 withtimeout_ms: 1234; fails without the change (received 60000).