Repository navigation
fix(slack): name the bot user after the app when Slack accepts the name - #180
Merged
Merged
Conversation
Deploying mikan with
|
| Latest commit: |
45e7c21
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2c6f80c7.mikan-1wv.pages.dev |
| Branch Preview URL: | https://fix-slack-bot-name.mikan-1wv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
mikan slack set --name(and the name asked bymikan onboard) now also sets the bot user's display name, the name people see on the bot's messages. Before, the bot stayedmikanwhatever the app was called, so syncing an app namedPiwould have renamed its bot tomikan.Slack accepts only letters, digits, spaces,
.,_, and-(up to 80) in a bot's display name, because it derives the bot's username from it; the app name itself may be any text. For a name outside that set, such as a Chinese one, the bot staysmikanand the CLI says why, instead of sending a manifest Slack rejects.Verification
apps.manifest.validateagainst a test app:Pi→ botPi, valid;小橘andPi 助理→ botmikan, valid. Sending小橘orPi 助理as the bot name directly fails withbad_username;Pi!fails withinvalid_name_specials.