Repository navigation
fix(deps): upgrade Pi to 1.2.0 - #181
Merged
Merged
Conversation
Deploying mikan with
|
| Latest commit: |
7d023e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98fb75a6.mikan-1wv.pages.dev |
| Branch Preview URL: | https://chore-pi-1-2.mikan-1wv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pi 1.2.0 (released 2026-10-12 23:00 UTC) removed
mcpStructuredContentSchemafrom@earendil-works/pi-codemode. mikan depends on^1.1.0, so a fresh install of the published mikan 1.4.0 now resolves Pi 1.2.0 and crashes on start (verified:mikan --versionthrowsSyntaxError: ... does not provide an export named 'mcpStructuredContentSchema'). Running installs keep Pi 1.1.0 until they reinstall. main's package-install check fails the same way.What
Dependencies move to
^1.2.0, adapted to Pi 1.2's breaking changes:mcpStructuredContentSchemaremoved;renderToolOutputTypeno longer treats MCP results speciallyToolExecutionResult.contentrenamedoutputMikanToolResult.content;toPiToolinsession.tsconverts at the registration boundary, and Pi's own read/write/edit/bash results convert back inwithLabel. The loop-guard notice is appended tooutputin the Pi hookbashanswers a nonzero exit with an error result and anexit_codediagnostic instead of throwingMikanToolResultcarriesdiagnostics; tests assert the error resultToolExecutionApigainsretainedOutputandexecuteToolWithout the
content→outputconversion every mikan tool's output would silently reach the model empty; 19 existing tests fail when it is removed.Not adopted here: Pi 1.2's native codemode (
pi-durable/codemode), nested tool calls, structured output, and deferred tools overlap mikan's own codemode andtool_search; moving to them is a separate change.Verification