8000 fix(tools): jev_browser ignores an empty handOff and opens a url alone by geminixiang · Pull Request #183 · geminixiang/mikan · GitHub
[go: up one dir, main page]

Skip to content

fix(tools): jev_browser ignores an empty handOff and opens a url alone - #183

Merged
geminixiang merged 2 commits into
mainfrom
fix/jev-browser-empty-handoff
Oct 13, 2026
Merged

geminixiang merged 2 commits into
mainfrom
fix/jev-browser-empty-handoff

Conversation

@geminixiang
@geminixiang geminixiang commented Oct 13, 2026 •
Copy link
Copy Markdown
Owner

Why

Two kinds of failed jev_browser calls in production today:

  1. Models that fill every optional field sent handOff: "" together with url and goal when asked to open a page. jev_browser took any defined handOff as a hand-off request and refused with "Use handOff alone…"; the model retried the same call until the loop guard stopped it (3 failures).
  2. Asked to "open the browser" on a page, the model passed only url, which was refused ("Provide goal or commands"); it then made up a goal such as "open the page and confirm it loads", which ran the goal loop for 16–30 s.

What

  • An empty or whitespace handOff counts as not given, and a real hand-off ignores frame: "main" (the top page).
  • url alone opens the page and returns { status: "opened", finalUrl, title, browserContinuity }, without a snapshot or the goal loop. A call with none of url, goal, or commands is still refused.

Verification

  • Tests: an empty handOff with filled defaults runs the commands and opens no desktop (fails without the fix with the production error); a real handOff with empty defaults hands off; url alone sends one open and reports the final URL and title.
  • Real container: url alone opened example.com in 1.7 s and returned finalUrl and title: "Example Domain".
  • Gate: 2174 tests pass
  • CI
  • Slack E2E: 26 of 26 (run loop and its tools)

@geminixiang geminixiang changed the title fix(tools): treat an empty jev_browser handOff as not given fix(tools): jev_browser ignores an empty handOff and opens a url alone Oct 13, 2026
@geminixiang
geminixiang force-pushed the fix/jev-browser-empty-handoff branch from 1ff34bd to e67d830 Compare October 13, 2026 03:36
@geminixiang
geminixiang merged commit e8409fb into main Oct 13, 2026
5 checks passed
@geminixiang
geminixiang deleted the fix/jev-browser-empty-handoff branch October 13, 2026 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0