8000 Streamline GEMINI.md and add core C++, DSLX, and testing guidelines. by copybara-service[bot] · Pull Request #5404 · google/xls · GitHub
[go: up one dir, main page]

Skip to content

Streamline GEMINI.md and add core C++, DSLX, and testing guidelines. - #5404

Draft
copybara-service[bot] wants to merge 1 commit into
mainfrom
test_1021160562
Draft

copybara-service[bot] wants to merge 1 commit into
mainfrom
test_1021160562

Conversation

@copybara-service
Copy link
Copy Markdown

Streamline GEMINI.md and add core C++, DSLX, and testing guidelines.

GEMINI.md previously spent 40% of its lines on a scratch-directory local export walkthrough and absl::optional_ref initialization details while omitting the C++, DSLX, and test-verification conventions that recur most often in code reviews.

Move the absl::optional_ref XLS_ASSIGN_OR_RETURN initialization note and idiomatic DSLX guidelines into docs_src/xls_style.md, replace the inline local export recipe with a reference to the OSS flow documentation, clarify the presubmit confirmation warning so XLS_EXPORT_PR=1 is still included on draft CLs, and add concise guidelines in GEMINI.md (and oss/OSS_GEMINI.md) covering helper reuse, error propagation, Codegen 1.5 targeting, idiomatic DSLX, diffbase failure verification for regression tests, and comment hygiene.

`GEMINI.md` previously spent 40% of its lines on a scratch-directory local export walkthrough and `absl::optional_ref` initialization details while omitting the C++, DSLX, and test-verification conventions that recur most often in code reviews.

Move the `absl::optional_ref` `XLS_ASSIGN_OR_RETURN` initialization note and idiomatic DSLX guidelines into `docs_src/xls_style.md`, replace the inline local export recipe with a reference to the OSS flow documentation, clarify the presubmit confirmation warning so `XLS_EXPORT_PR=1` is still included on draft CLs, and add concise guidelines in `GEMINI.md` (and `oss/OSS_GEMINI.md`) covering helper reuse, error propagation, Codegen 1.5 targeting, idiomatic DSLX, diffbase failure verification for regression tests, and comment hygiene.

PiperOrigin-RevId: 1021160562

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0