Repository navigation
Streamline GEMINI.md and add core C++, DSLX, and testing guidelines. - #5404
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
`GEMINI.md` previously spent 40% of its lines on a scratch-directory local export walkthrough and `absl::optional_ref` initialization details while omitting the C++, DSLX, and test-verification conventions that recur most often in code reviews. Move the `absl::optional_ref` `XLS_ASSIGN_OR_RETURN` initialization note and idiomatic DSLX guidelines into `docs_src/xls_style.md`, replace the inline local export recipe with a reference to the OSS flow documentation, clarify the presubmit confirmation warning so `XLS_EXPORT_PR=1` is still included on draft CLs, and add concise guidelines in `GEMINI.md` (and `oss/OSS_GEMINI.md`) covering helper reuse, error propagation, Codegen 1.5 targeting, idiomatic DSLX, diffbase failure verification for regression tests, and comment hygiene. PiperOrigin-RevId: 1021160562
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamline GEMINI.md and add core C++, DSLX, and testing guidelines.
GEMINI.mdpreviously spent 40% of its lines on a scratch-directory local export walkthrough andabsl::optional_refinitialization details while omitting the C++, DSLX, and test-verification conventions that recur most often in code reviews.Move the
absl::optional_refXLS_ASSIGN_OR_RETURNinitialization note and idiomatic DSLX guidelines intodocs_src/xls_style.md, replace the inline local export recipe with a reference to the OSS flow documentation, clarify the presubmit confirmation warning soXLS_EXPORT_PR=1is still included on draft CLs, and add concise guidelines inGEMINI.md(andoss/OSS_GEMINI.md) covering helper reuse, error propagation, Codegen 1.5 targeting, idiomatic DSLX, diffbase failure verification for regression tests, and comment hygiene.