Repository navigation
xls: Emit a warning when DSLX test or quickcheck runners find no tests - #5411
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
When running `interpreter_main` or `prove_quickcheck_main` on a DSLX module that has no test annotations (`#[test]`, `#[test_proc]`, or `#[quickcheck]`), the runner previously printed `0 test(s) ran; 0 failed; 0 skipped.` and exited 0 without noting that no test functions were present in the module. - Emit a clear `WARNING:` message to `std::cerr` in `AbstractTestRunner::ParseAndTest` when a module contains neither unit tests (`#[test]` / `#[test_proc]`) nor `#[quickcheck]` properties. - Emit a corresponding `WARNING:` message in `ParseAndProve` when a module contains no `#[quickcheck]` properties. - Add unit tests in `xls/dslx/run_routines/run_routines_test.cc` and `xls/dslx/interpreter_test.py` verifying the warning output. PiperOrigin-RevId: 1021571820
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xls: Emit a warning when DSLX test or quickcheck runners find no tests
When running
interpreter_mainorprove_quickcheck_mainon a DSLX module that has no test annotations (#[test],#[test_proc], or#[quickcheck]), the runner previously printed0 test(s) ran; 0 failed; 0 skipped.and exited 0 without noting that no test functions were present in the module.WARNING:message tostd::cerrinAbstractTestRunner::ParseAndTestwhen a module contains neither unit tests (#[test]/#[test_proc]) nor#[quickcheck]properties.WARNING:message inParseAndProvewhen a module contains no#[quickcheck]properties.xls/dslx/run_routines/run_routines_test.ccandxls/dslx/interpreter_test.pyverifying the warning output.