Repository navigation
fix(eval): delete current eval cases independently of tab mounting - #563
Open
Aaravkhanal wants to merge 1 commit into
Open
Aaravkhanal wants to merge 1 commit into
Aaravkhanal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #547.
Deleting the current eval case could show “Eval case deleted” without making a DELETE request: ChatComponent queried EvalTabComponent directly, but the tab is owned and dynamically created by SidePanelComponent.
The detail-view action now calls EvalService with the app, eval set, and case captured when confirmation opens. It shows success only after the DELETE succeeds, and reports failure while preserving the case when the request fails. After success, it clears the deleted detail view and asks the side panel to refresh its matching eval tab. The refresh uses the existing post-fetch table update and next-case selection logic; the redundant pre-fetch detectChanges call is removed. A different selected case or eval set is preserved.
Validation:
npm run buildpasses with existing dependency/bundle warnings.git diff --checkpasses.No live backend/browser end-to-end test was run. PR #390 changes snackbar styling but retains the original optional deletion call; this PR fixes the request and success timing. I also saw the issue reporter’s comment about a prepared fix; I found no published competing PR when checking and am happy to coordinate if one is already in progress.
Live verification finding
Started this branch with a local google-adk 2.14.0 backend and a disposable eval set. The eval set and detail view load, but the current ChatComponent template has no binding to
deleteEvalCase(). The visible eval-list delete action calls EvalTabComponent instead. Consequently this PR's chat-handler fix is unit-tested but has not been exercised through a user-accessible detail-view delete button. This is a material validation gap: the missing detail action/wiring needs resolving before claiming the reported workflow is fixed end-to-end.