8000 resolves hedgedoc#6138: improve nginx config docs by Happy86 · Pull Request #6149 · hedgedoc/hedgedoc · GitHub
[go: up one dir, main page]

Skip to content

resolves hedgedoc#6138: improve nginx config docs - #6149

Merged
ErikMichelson merged 1 commit into
hedgedoc:masterfrom
Happy86:fix-hedgedoc-issue-6138-nginx-config
Nov 12, 2025
Merged

ErikMichelson merged 1 commit into
hedgedoc:masterfrom
Happy86:fix-hedgedoc-issue-6138-nginx-config

Conversation

@Happy86
@Happy86 Happy86 commented Nov 11, 2025
Copy link
Copy Markdown
  • remove deprecated http2-parameter from listen-directive since it has been deprecated since NGINX v1.25.1
  • add warning box for those running on an older nginx version on how to re-add the parameter
  • add information box with a hint about limiting access to the the stats API without completely disabling it

Component/Part

  • documentation

Description

This PR fixes #6138 and adds additional information on how to limit access to the stats API to trusted networks.

Hope it's ok to also add the info about limiting access to the stats API without adding a separate issue (with the suggestion of adding this information). If not please tell me and I'll remove it from this PR.

Also I used mkdocs to render the new documentation locally. Here are two screenshots:

Bildschirmfoto 2025-11-11 um 16 51 42
Bildschirmfoto 2025-11-11 um 16 52 14

Steps

  • [-] Added implementation
  • [-] Added / updated tests
  • Added / updated documentation
  • [-] Added changelog snippet
  • I read the contribution documentation and
    made sure that:
    • My commits are signed-off to accept the DCO.
    • This PR targets the correct branch: master for 1.x & docs, develop for 2.x

Related Issue(s)

#6138

@Happy86 Happy86 changed the title resolves hedgedoc#6147: improve nginx config docs resolves hedgedoc##6138: improve nginx config docs Nov 11, 2025
@Happy86 Happy86 changed the title resolves hedgedoc##6138: improve nginx config docs resolves hedgedoc#6138: improve nginx config docs Nov 11, 2025
@Happy86
Happy86 force-pushed the fix-hedgedoc-issue-6138-nginx-config branch from e4f8a68 to 0635679 Compare November 11, 2025 16:15
* remove deprecated http2-parameter from listen-directive since it has
  been deprecated since NGINX v1.25.1
* add warning box for those running on an older nginx version on how to
  re-add the parameter
* add information box with a hint about limiting access to the the stats
  API without completely disabling it

Signed-off-by: Andreas Boesen <boesen@belwue.de>
@Happy86
Happy86 force-pushed the fix-hedgedoc-issue-6138-nginx-config branch from 0635679 to 9cd8835 Compare November 11, 2025 19:40
@ErikMichelson ErikMichelson left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great fix and addition to the docs as well! 🚀

@ErikMichelson
ErikMichelson enabled auto-merge (squash) November 12, 2025 08:24
@ErikMichelson
ErikMichelson merged commit 78cac15 into hedgedoc:master Nov 12, 2025
5 checks passed
@Happy86
Happy86 deleted the fix-hedgedoc-issue-6138-nginx-config branch November 12, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0