Repository navigation
fix: Dont return toobusy errors for healthchecks. - #6102
Merged
ErikMichelson merged 2 commits intoAug 14, 2025
Merged
Conversation
ErikMichelson
approved these changes
Aug 14, 2025
Member
There was a problem hiding this comment.
Looks good, thank you for this contribution!
If running with an orchestrator that restarts hedgedoc on failing healthchecks, this causes it to enter a crashloop. toobusy -> gets restarted -> everyone refreshes -> toobusy Signed-off-by: Daniel Koschützki <daniel.koschuetzki@adfinis.com>
ErikMichelson
force-pushed
the
fix/toobusy-healthchecks
branch
from
August 14, 2025 13:27
9dc1cf5 to
4cf355d
Compare
Signed-off-by: Erik Michelson <github@erik.michelson.eu>
ErikMichelson
force-pushed
the
fix/toobusy-healthchecks
branch
from
August 14, 2025 13:28
4cf355d to
a451d13
Compare
ErikMichelson
enabled auto-merge (rebase)
August 14, 2025 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component/Part
Health checks
Description
When running on e.g. Kubernetes, failing health checks will cause hedgedoc to be restarted. 503 "too busy" errors count as failing.
This PR adds a special case to the too busy middleware, to ensure the /_health endpoint never gives toobusy errors.
Steps
made sure that:
masterfor 1.x & docs,developfor 2.xRelated Issue(s)