8000 Fixed the wrong vars in docker/.env by pl7ofit · Pull Request #6106 · hedgedoc/hedgedoc · GitHub
[go: up one dir, main page]
Skip to content

Fixed the wrong vars in docker/.env - #6106

Merged
ErikMichelson merged 1 commit into
hedgedoc:developfrom
pl7ofit:docker-compose-fix-env-variables
Aug 14, 2025
Merged

Fixed the wrong vars in docker/.env#6106
ErikMichelson merged 1 commit into
hedgedoc:developfrom
pl7ofit:docker-compose-fix-env-variables

Conversation

@pl7ofit
@pl7ofit pl7ofit commented Aug 6, 2025
Copy link
Copy Markdown
Contributor

Component/Part

I simply fix wrong variables names in docker/.env and docker/docker-compose.yaml

Description

The fix was needed because I got an error on startup:

backend-1   | [HedgeDoc.NestFactory()] Starting Nest application...
backend-1   | [HedgeDoc.ExceptionHandler()] There were some errors with your configuration: - HD_DATABASE_USERNAME: Required - HD_DATABASE_PASSWORD: RequiredFor further information, have a look at our configuration docs at https://docs.hedgedoc.org/configuration
backend-1   | Error: There were some errors with your configuration:
backend-1   |  - HD_DATABASE_USERNAME: Required
backend-1   |  - HD_DATABASE_PASSWORD: Required

@cypress
cypress Bot commented Aug 6, 2025 •
edited
Loading
Copy link
Copy Markdown

HedgeDoc    Run #8090

Run Properties:  status check failed Failed #8090  •  git commit 6283eb0835: Fixed the wrong vars in .env
Project HedgeDoc
Branch Review docker-compose-fix-env-variables
Run status status check failed Failed #8090
Run duration 05m 05s
Commit git commit 6283eb0835: Fixed the wrong vars in .env
Committer Yaroslav Lakaev
View all properties for this run ↗︎
Test results
Tests that failed  Failures 45
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 2
Tests that passed  Passing 43
View all changes introduced in this branch ↗︎

Tests for review

Failed  documentTitle.spec.ts • 12 failed tests • chrome

View Output

Test Artifacts
Document Title > title should be yaml metadata title > just yaml metadata title Test Replay Screenshots
Document Title > title should be yaml metadata title > yaml metadata title and opengraph title Test Replay Screenshots
Document Title > title should be yaml metadata title > yaml metadata title, opengraph title and first heading Test Replay Screenshots
Document Title > title should be opengraph title > just opengraph title Test Replay Screenshots
Document Title > title should be opengraph title > opengraph title and first heading Test Replay Screenshots
Document Title > title should be first heading > just first heading Test Replay Screenshots
Document Title > title should be first heading > just first heading with alt-text instead of image Test Replay Screenshots
Document Title > title should be first heading > just first heading without link syntax Test Replay Screenshots
Document Title > title should be first heading > markdown syntax removed first Test Replay Screenshots
Document Title > title should be first heading > markdown syntax removed second Test Replay Screenshots
The first 10 failed tests are shown, see all 12 tests in Cypress Cloud.
Failed  linkSchemes.spec.ts • 10 failed tests • chrome

View Output

Test Artifacts
markdown formatted links to > external domains render as external link Test Replay Screenshots
markdown formatted links to > note anchor references render as anchor link Test Replay Screenshots
markdown formatted links to > internal pages render as internal link Test Replay Screenshots
markdown formatted links to > data URIs do not render Test Replay Screenshots
markdown formatted links to > javascript URIs do not render Test Replay Screenshots
HTML anchor element links to > external domains render as external link Test Replay Screenshots
HTML anchor element links to > note anchor references render as anchor link Test Replay Screenshots
HTML anchor element links to > internal pages render as internal link Test Replay Screenshots
HTML anchor element links to > data URIs do not render Test Replay Screenshots
HTML anchor element links to > javascript URIs do not render Test Replay Screenshots
Failed  taskLists.spec.ts • 4 failed tests • chrome

View Output

Test Artifacts
Task lists > do not render as checkboxes when invalid Test Replay Screenshots
Task lists > render with checkboxes > when unchecked Test Replay Screenshots
Task lists > render with checkboxes > when checked lowercase Test Replay Screenshots
Task lists > render with checkboxes > when checked uppercase Test Replay Screenshots
Failed  word-count.spec.ts • 3 failed tests • chrome

View Output

Test Artifacts
Test word count with > simple words Test Replay Screenshots
Test word count with > excluded codeblocks Test Replay Screenshots
Test word count with > excluded images Test Replay Screenshots
Failed  maxLength.spec.ts • 3 failed tests • chrome

View Output

Test Artifacts
The status bar text length info > color is set to "warning" on <= 100 characters remaining Test Replay Screenshots
The status bar text length info > color is set to danger on <= 0 characters remaining Test Replay Screenshots
The status bar text length info > opens a modal Test Replay Screenshots

The first 5 failed specs are shown, see all 13 specs in Cypress Cloud.

ErikMichelson
ErikMichelson approved these changes Aug 14, 2025
View reviewed changes
@ErikMichelson ErikMichelson left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes, this docker folder is still some subject to change, but for now it's good to have it fixed.

@ErikMichelson
ErikMichelson commented Aug 14, 2025
Copy link
Copy Markdown
Member

Oh, sorry to bother again. One thing which is missing:

In order to get this merged, we need you to sign-off your commits according to the contribution guidelines for the HedgeDoc organization. You can find more information on this here: https://github.com/hedgedoc/hedgedoc/blob/develop/CONTRIBUTING.md#certificate-of-origin

@pl7ofit
pl7ofit force-pushed the docker-compose-fix-env-variables branch from df317b1 to 092dbca Compare August 14, 2025 13:25
@pl7ofit
Fixed the wrong vars in .env
6283eb0 
Signed-off-by: Yaroslav Lakaev <pl7ofit@ya.ru>
@pl7ofit
pl7ofit force-pushed the docker-compose-fix-env-variables branch from 092dbca to 6283eb0 Compare August 14, 2025 13:29
@pl7ofit
pl7ofit commented Aug 14, 2025
Copy link
Copy Markdown
Contributor Author

@ErikMichelson Thanks, I didn't realize there were such DCO rules. I fixed it.

@ErikMichelson
ErikMichelson enabled auto-merge (squash) August 14, 2025 13:40
@ErikMichelson
ErikMichelson merged commit d601157 into hedgedoc:develop Aug 14, 2025
73D3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikMichelson ErikMichelson ErikMichelson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pl7ofit @ErikMichelson
0