8000 Avoid direct access to executor to record worker pool metrics by ahus1 · Pull Request #22743 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Avoid direct access to executor to record worker pool metrics - #22743

Merged
ahus1 merged 1 commit into
keycloak:mainfrom
ahus1:is-22742-metrics-worker-pool
Sep 1, 2023
Merged

ahus1 merged 1 commit into
keycloak:mainfrom
ahus1:is-22742-metrics-worker-pool

Conversation

@ahus1
@ahus1 ahus1 commented Aug 28, 2023
Copy link
Copy Markdown
Member

Closes #22742

@ahus1
ahus1 commented Aug 29, 2023
Copy link
Copy Markdown
Member Author

@pedroigor - I wonder if you could review as it partly undoes some of changes done in #15192: Instead of using the executor directly, it uses the standard Vert.x mechanisms to execute blocking code.

Thanks!

cc: @vmuzikar

@ahus1
ahus1 requested a review from pedroigor August 29, 2023 10:36
@ahus1
ahus1 commented Sep 1, 2023
Copy link
Copy Markdown
Member Author

@pedroigor - I know that this change will be obsolete once RESTEasy reactive is used. Still, if this is some time away, I'd be happy to have this merged so we can collect metrics for this. It might even be worth backporting it to KC22 if it proves useful, while RESTEasy reactive will only be part of KC23 only.

@pedroigor pedroigor left a comment •
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahus1 LGTM. I agree we should backport this one.

@ahus1
ahus1 merged commit 8c5818a into keycloak:main Sep 1, 2023
@ahus1
ahus1 deleted the is-22742-metrics-worker-pool branch September 21, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing metrics for worker_pool_*

2 participants

0