8000 Workaround for Vert.x to when probes are rejected from the executor pool by ahus1 · Pull Request #23920 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Workaround for Vert.x to when probes are rejected from the executor pool - #23920

Closed
ahus1 wants to merge 1 commit into
keycloak:mainfrom
ahus1:is-23919-make-block-checks-parallel
Closed

Workaround for Vert.x to when probes are rejected from the executor pool#23920
ahus1 wants to merge 1 commit into
keycloak:mainfrom
ahus1:is-23919-make-block-checks-parallel

Conversation

@ahus1
@ahus1 ahus1 commented Oct 11, 2023 •
edited
Loading
Copy link
Copy Markdown
Member

Closes #23919

Update:

@ahus1 ahus1 self-assigned this Oct 11, 2023
@ahus1
ahus1 force-pushed the is-23919-make-block-checks-parallel branch from d1a95de to 8cbed98 Compare October 11, 2023 19:48
@ghost ghost added the flaky-test label Oct 11, 2023
This was referenced Oct 11, 2023
Closed
Closed
Closed
Closed
ghost
ghost reviewed Oct 11, 2023
View reviewed changes
@ghost ghost left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
ghost commented Oct 11, 2023
Copy link
Copy Markdown

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.ui.account2.SessionTest#welcomeScreenSsoTimeoutTest

Keycloak CI - Account Console IT (firefox)

java.lang.AssertionError: Header button should be visible expected:<true> but was:<false>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.keycloak.testsuite.ui.account2.page.fragment.AbstractHeader.assertToolsBtnVisible(AbstractHeader.java:94)
...

Report flaky test

@ghost ghost mentioned this pull request Oct 11, 2023
Closed
@ahus1
ahus1 marked this pull request as ready for review October 13, 2023 13:50
@ahus1
ahus1 requested review from a team as code owners October 13, 2023 13:50
@ahus1 ahus1 mentioned this pull request Oct 13, 2023
Merged
@ahus1
ahus1 force-pushed the is-23919-make-block-checks-parallel branch from 8cbed98 to 23b8bc6 Compare October 16, 2023 14:13
@ahus1
ahus1 commented Oct 16, 2023
Copy link
Copy Markdown
Member Author

@mabartos / @pedroigor - this is a follow-up for two issues discovered in Quarkus and Vert.x around the probes. Both changes have already been merged upstream, and are waiting for a future release.

Please review it when you have the time.

The build was already green before; the only change I just did was add a reference to the issue tracking the removal of the workaround.

cc: @vmuzikar

@ahus1
ahus1 commented Oct 18, 2023
Copy link
Copy Markdown
Member Author

This PR might become obsolete when #23343 is merged. But that PR waits for some initial feedback from Quarkus upstream. One of these PRs should be merged for KC23.

@ahus1 ahus1 modified the milestone: 23.0.0 Oct 18, 2023
@ahus1
ahus1 commented Nov 20, 2023
Copy link
Copy Markdown
Member Author

Due to the update

This is no longer necessary.

@ahus1 ahus1 closed this Nov 20, 2023
@ahus1
ahus1 deleted the is-23919-make-block-checks-parallel branch March 4, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Limiting the Quarkus executor is not compatible with async readiness probe

1 participant

@ahus1
0