8000 Add regex support in 'Condition - User attribute' execution by cgeorgilakis · Pull Request #23169 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Add regex support in 'Condition - User attribute' execution - #23169

Merged
mposolda merged 1 commit into
keycloak:mainfrom
eosc-kc:265_condition_userattribute
Sep 13, 2023
Merged

Add regex support in 'Condition - User attribute' execution#23169
mposolda merged 1 commit into
keycloak:mainfrom
eosc-kc:265_condition_userattribute

Conversation

@cgeorgilakis
@cgeorgilakis cgeorgilakis commented Sep 12, 2023
Copy link
Copy Markdown
Contributor

Closes #265

@cgeorgilakis
cgeorgilakis requested review from a team as code owners September 12, 2023 10:33
@cgeorgilakis
cgeorgilakis requested a review from a team September 12, 2023 10:33
@cgeorgilakis
cgeorgilakis requested a review from a team as a code owner September 12, 2023 10:33
This was referenced Sep 12, 2023
Closed
Closed
Closed
Closed
mposolda
mposolda approved these changes Sep 13, 2023
View reviewed changes
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgeorgilakis LGTM, Thanks for adding this!

@mposolda
mposolda merged commit 0044472 into keycloak:main Sep 13, 2023
@mposolda mposolda linked an issue Sep 13, 2023 that may be closed by this pull request
Add regex support in 'Condition - User attribute' execution #23194
Closed
@mposolda
mposolda commented Sep 13, 2023
Copy link
Copy Markdown
Contributor

@cgeorgilakis I figured wrong issue was linked to this, so I've created new issue #23194 and linked with this PR

@cgeorgilakis
cgeorgilakis commented Sep 13, 2023
Copy link
Copy Markdown
Contributor Author

Thanks @mposolda.
I have create the issue in wrong place.

My description was (if you want to change the issue description) :

'Condition - User attribute' execution does not allow searching user attribute with regex.
We will add boolean regex. If user select regex, 'Condition - User attribute' execution search will be based on regular expression. default regex value will be false (keeping same behaviour as current Keycloak).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes
0