Repository navigation
Implement load shedding for RESTEasy reactive #23343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ahus1
wants to merge
1
commit into
keycloak:main
from
ahus1:is-23340-load-shedding-resteasy-reactive
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
112 changes: 112 additions & 0 deletions
112
...ntime/src/main/java/org/keycloak/quarkus/runtime/integration/web/LoadSheddingHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| /* | ||
| * Copyright 2023 Red Hat, Inc. and/or its affiliates | ||
| * and other contributors as indicated by the @author tags. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.keycloak.quarkus.runtime.integration.web; | ||
|
|
||
| import java.util.Optional; | ||
| import java.util.concurrent.Semaphore; | ||
| import java.util.concurrent.atomic.LongAdder; | ||
| import java.util.function.Predicate; | ||
|
|
||
| import org.apache.http.HttpStatus; | ||
| import org.jboss.logging.Logger; | ||
|
|
||
| import io.vertx.core.Handler; | ||
| import io.vertx.ext.web.RoutingContext; | ||
| import org.keycloak.quarkus.runtime.configuration.Configuration; | ||
|
|
||
| /** | ||
| * Limit the number of concurrent requests (both blocking and non-blocking) to a configured upper limit. | ||
| * Special paths (like for health probes and metrics) can be excluded, so their requests will not be dropped. | ||
| * | ||
| * @author Alexander Schwartz | ||
| */ | ||
| public class LoadSheddingHandler implements Handler<RoutingContext> { | ||
|
|
||
| private final Logger logger = Logger.getLogger(LoadSheddingHandler.class); | ||
|
|
||
| private final Predicate<RoutingContext> contextFilter; | ||
|
|
||
| private final Semaphore available; | ||
|
|
||
| public LoadSheddingHandler() { | ||
| this(null); | ||
| } | ||
|
|
||
| public LoadSheddingHandler(Predicate<RoutingContext> contextFilter) { | ||
| Optional<String> maxConcurrentRequests = Configuration.getRuntimeProperty("kc.http-max-concurrent-requests"); | ||
| if (maxConcurrentRequests.isPresent()) { | ||
| available = new Semaphore(Integer.parseInt(maxConcurrentRequests.get()), false); | ||
| } else { | ||
| available = null; | ||
| } | ||
| this.contextFilter = contextFilter; | ||
| } | ||
|
|
||
| private final LongAdder rejectedRequests = new LongAdder(); | ||
| private volatile boolean loadSheddingActive; | ||
|
|
||
| @Override | ||
| public void handle(RoutingContext context) { | ||
| if (available == null || ignoreContext(context)) { | ||
| context.next(); | ||
| return; | ||
| } | ||
| if (available.tryAcquire()) { | ||
| context.addEndHandler(event -> { | ||
| available.release(); | ||
| }); | ||
| if (loadSheddingActive) { | ||
| Long req = null; | ||
| synchronized (rejectedRequests) { | ||
| if (loadSheddingActive) { | ||
| loadSheddingActive = false; | ||
| // rejectedRequests.sumThenReset() is approximative when concurrent increments are active, still it should be accurate enough for this log message | ||
| req = rejectedRequests.sumThenReset(); | ||
| } | ||
| } | ||
| if (req != null) { | ||
| // this avoids logging in a synchronized block | ||
| logger.warnf("Executor thread pool no longer exhausted, request processing continued after %s discarded request(s)", req); | ||
| } | ||
| } | ||
| context.next(); | ||
| } else { | ||
| boolean logExhausted = false; | ||
| if (!loadSheddingActive) { | ||
| synchronized (rejectedRequests) { | ||
| if (!loadSheddingActive) { | ||
| loadSheddingActive = true; | ||
| logExhausted = true; | ||
| } | ||
| } | ||
| } | ||
| if (logExhausted) { | ||
| // this avoids logging in a synchronized block | ||
| logger.warn("Executor thread pool exhausted, starting to reject requests"); | ||
| } | ||
| rejectedRequests.increment(); | ||
| // if the thread pool has been configured with a maximum queue size, it might reject the request | ||
| context.fail(HttpStatus.SC_SERVICE_UNAVAILABLE); | ||
| } | ||
| } | ||
|
|
||
| private boolean ignoreContext(RoutingContext context) { | ||
| return contextFilter != null && contextFilter.test(context); | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.