8000 Removing version overrides and further aligning with quarkus versions by shawkins · Pull Request #26788 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Removing version overrides and further aligning with quarkus versions - #26788

Merged
vmuzikar merged 6 commits into
keycloak:mainfrom
shawkins:iss26535
Feb 7, 2024
Merged

vmuzikar merged 6 commits into
keycloak:mainfrom
shawkins:iss26535

Conversation

@shawkins
@shawkins shawkins commented Feb 5, 2024 •
Copy link
Copy Markdown
Contributor

This further aligns us to quarkus versions and removes some test overrides where we can use the quarkus version.

closes #26535

cc @Pepo48 @vmuzikar

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Thank you for this PR!

I wonder if we still need to keep the explicitly set versions for resteasy, db drivers and elytron. Can't we just rely on Quarkus BOM with those too?

@shawkins
shawkins commented Feb 6, 2024
Copy link
Copy Markdown
Contributor Author

I wonder if we still need to keep the explicitly set versions for resteasy, db drivers and elytron. Can't we just rely on Quarkus BOM with those too?

No, we make use of all of those versions in some way that is not covered by the bom import. There's some description of that in the issue.

@Pepo48 Pepo48 left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @shawkins.

@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Ah, right, thanks!

@keycloak/store Do you want to review as well since this concerns DB drivers?

@abstractj
abstractj requested a review from a team February 7, 2024 16:51
@ahus1 ahus1 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the store team. Thank you for this change!

@vmuzikar
vmuzikar merged commit 402c7d9 into keycloak:main Feb 7, 2024
cavuugroup pushed a commit to cavuugroup/keycloak that referenced this pull request Feb 8, 2024
…keycloak#26788)

* elevating wildfly-elytron-http-oidc version management

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* removing testing dependency overrides

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* further version aligment with quarkus

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* adding a resteay-core-spi that can be overriden

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* removing hamcrest override

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* aligning with 3.7.1

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

---------

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Post Quarkus 3.7 dependency alignment

4 participants

0