8000 #26826 fix for Freemarker erroneously escapes/sanitizes URL in template.ftl (&) by dominiktopp · Pull Request #26838 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

#26826 fix for Freemarker erroneously escapes/sanitizes URL in template.ftl (&) - #26838

Merged
mposolda merged 1 commit into
keycloak:mainfrom
dominiktopp:issue-26826
Feb 8, 2024
Merged

mposolda merged 1 commit into
keycloak:mainfrom
dominiktopp:issue-26826

Conversation

@dominiktopp
@dominiktopp dominiktopp commented Feb 6, 2024 •
Copy link
Copy Markdown
Contributor

closes #26826

Fix for #26826 as suggested in #26826 (comment)

@dominiktopp
dominiktopp requested a review from a team as a code owner February 6, 2024 16:33
@rmartinc
rmartinc commented Feb 6, 2024
Copy link
Copy Markdown
Contributor

Please @dominiktopp, add your signature in the commit, git commit -s --amend for example.

@dominiktopp
Copy link
Copy Markdown
Contributor Author

Please @dominiktopp, add your signature in the commit, git commit -s --amend for example.

Will do it tomorrow 👍

@dominiktopp
Copy link
Copy Markdown
Contributor Author

@rmartinc is the signature ok now?

Signed-off-by: Dominik Topp <19268966+dominiktopp@users.noreply.github.com>
@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dominiktopp! Yes, it's correct now. Let's see how the tests go.

@mposolda
mposolda merged commit edd68d1 into keycloak:main Feb 8, 2024
cavuugroup pushed a commit to cavuugroup/keycloak that referenced this pull request Feb 8, 2024
…k#26838)

closes keycloak#26826

Signed-off-by: Dominik Topp <19268966+dominiktopp@users.noreply.github.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
rmartinc pushed a commit to rmartinc/keycloak that referenced this pull request Feb 8, 2024
…k#26838)

closes keycloak#26826

Signed-off-by: Dominik Topp <19268966+dominiktopp@users.noreply.github.com>
(cherry picked from commit edd68d1)
mposolda pushed a commit that referenced this pull request Feb 8, 2024
closes #26826

Signed-off-by: Dominik Topp <19268966+dominiktopp@users.noreply.github.com>
(cherry picked from commit edd68d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment 6E4E

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Freemarker erroneously escapes/sanitizes URL in template.ftl (&amp;)

3 participants

0