8000 chore: clarify default creds in readme, add .vscode to gitignore by gitdallas · Pull Request #26840 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

chore: clarify default creds in readme, add .vscode to gitignore - #26840

Merged
jonkoops merged 2 commits into
keycloak:mainfrom
gitdallas:chore/readme-gitignore-updates
Feb 7, 2024
Merged

jonkoops merged 2 commits into
keycloak:mainfrom
gitdallas:chore/readme-gitignore-updates

Conversation

@gitdallas
Copy link
Copy Markdown
Contributor

just making it a little more clear that the default creds are admin for both username and password.

also adding .vscode to gitignore (i'm using this to exclude most directories from my vscode searches)

Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
@gitdallas
gitdallas requested review from a team as code owners February 6, 2024 19:05
@jonkoops jonkoops left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jonkoops
jonkoops enabled auto-merge (squash) February 6, 2024 21:45
@cypress
cypress Bot commented Feb 6, 2024
Copy link
Copy Markdown

1 flaky test on run #10941 ↗︎

0 554 54 0 Flakiness 1

Details:

Merge 9c7347f into da69bee...
Project: Keycloak Admin UI Commit: f5054a3e3f ℹ️
Status: Passed Duration: 08:13 💡
Started: Feb 6, 2024 9:58 PM Ended: Feb 6, 2024 10:06 PM
Flakiness  cypress/e2e/clients_test.spec.ts • 1 flaky test • chrome

View Output

Test Artifacts
Clients test > Client details - Client scopes subtab > Should search non-existent client scope by name Test Replay Screenshots

Review all test suite changes for PR #26840 ↗︎

@ahus1 ahus1 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

@jonkoops
jonkoops merged commit 17abda5 into keycloak:main Feb 7, 2024
cavuugroup pushed a commit to cavuugroup/keycloak that referenced this pull request Feb 8, 2024
…cloak#26840)

Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0