Repository navigation
Add cookie type builder - #26848
Merged
Merged
Add cookie type builder#26848
Conversation
Closes keycloak#26847 Signed-off-by: stianst <stianst@gmail.com>
stianst
force-pushed
the
cookie-type-builder
branch
from
February 7, 2024 08:44
237e38d to
626db94
Compare
jonkoops
approved these changes
Feb 7, 2024
| private static class CookieTypeBuilder { | ||
|
|
||
| private String name; | ||
| private boolean supportSameSiteLegacy = false; |
Contributor
There was a problem hiding this comment.
Should we not be defaulting this to true for now?
Contributor
Author
There was a problem hiding this comment.
Nah, because it's an opt-in for specific cookie types.
pedroigor
approved these changes
Feb 7, 2024
cavuugroup
pushed a commit
to cavuugroup/keycloak
that referenced
this pull request
Feb 8, 2024
Closes keycloak#26847 Signed-off-by: stianst <stianst@gmail.com> Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26847