Repository navigation
task: adds event diagnostics for failed tests - #26864
Merged
Merged
Conversation
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Member
Contributor
Author
Not yet - this does not seem reproducible locally. |
mabartos
approved these changes
Feb 7, 2024
Member
There was a problem hiding this comment.
Works as expected. At least we have some additional info about events, nice job!
Just wondering whether there's any other option, as the format of the logging for Operator tests is kinda not very well readable.
As you can see the Feb 07, 2024 3:46:16 PM org.keycloak.operator.testsuite.integration.BaseOperatorTest logEvents is little bit overkilled here. I like the concatenation of the pckg name as Quarkus does.
f.e. 2024-02-07 15:58:17,584 INFO [io.qua.dep.QuarkusAugmentor] (main) Quarkus augmentation...
But it's out of scope of this PR.
LGTM like this.
Example log:
INFO: Event last seen 2024-02-07T14:45:56Z repeated 1 times - Normal SuccessfulCreate example-kc.17b19be85bf154eb create Pod example-kc-0 in StatefulSet example-kc successful
Feb 07, 2024 3:46:16 PM org.keycloak.operator.testsuite.integration.BaseOperatorTest logEvents
WARN: Event last seen 2024-02-07T14:45:56.027695Z repeated 1 times - Warning FailedScheduling example-kc-0.17b19be85bf6197b 0/1 nodes are available: 1 Insufficient cpu. preemption: 0/1 nodes are available: 1 No preemption victims found for incoming pod..
Feb 07, 2024 3:46:16 PM org.keycloak.operator.testsuite.integration.BaseOperatorTest logEvents
INFO: Event last seen 2024-02-07T14:45:55Z repeated 1 times - Normal Pulling postgresql-db-0.17b19be823bdcd0b Pulling image "quay.io/sclorg/postgresql-15-c9s:latest"
Feb 07, 2024 3:46:16 PM org.keycloak.operator.testsuite.integration.BaseOperatorTest logEvents
INFO: Event last seen 2024-02-07T14:45:55Z repeated 1 times - Normal Pulled postgresql-db-0.17b19be83ffeb029 Successfully pulled image "quay.io/sclorg/postgresql-15-c9s:latest" in 473.998164ms (474.002178ms including waiting)
Feb 07, 2024 3:46:16 PM org.keycloak.operator.testsuite.integration.BaseOperatorTest logEvents
INFO: Event last seen 2024-02-07T14:45:55Z repeated 1 times - Normal Created postgresql-db-0.17b19be841e30dcf Created container postgresql-db
Feb 07, 2024 3:46:16 PM org.keycloak.operator.testsuite.integration.BaseOperatorTest logEvents
INFO: Event last seen 2024-02-07T14:45:55Z repeated 1 times - Normal Started postgresql-db-0.17b19be845767c32 Started container postgresql-db
Feb 07, 2024 3:46:16 PM org.keycloak.operator.testsuite.integration.BaseOperatorTest logEvents
INFO: Event last seen 2024-02-07T14:45:54Z repeated 1 times - Normal SuccessfulCreate postgresql-db.17b19be80af2d533 create Pod postgresql-db-0 in StatefulSet postgresql-db successful
Feb 07, 2024 3:46:16 PM org.keycloak.operator.testsuite.integration.BaseOperatorTest logEvents
INFO: Event last seen 2024-02-07T14:45:54.672953Z repeated 1 times - Normal Scheduled postgresql-db-0.17b19be80b366b0e Successfully assigned keycloak-test-bf3ee95a-df23-48f8-8567-60606e4362b0/postgresql-db-0 to minikube
cavuugroup
pushed a commit
to cavuugroup/keycloak
that referenced
this pull request
Feb 8, 2024
Signed-off-by: Steve Hawkins <shawkins@redhat.com> Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.