Repository navigation
Fixed loading translation values for User Profile attributes - #28408
agagancarczyk wants to merge 10 commits into
Conversation
There was a problem hiding this comment.
Why not use the useFetch() utility here?
There was a problem hiding this comment.
sounds good @jonkoops , let's useFetch() instead
2d257af to
50ac40b
Compare
There was a problem hiding this comment.
I tried the code out and it's not working. When I click on the button to bring up the translations dialog I get a NullPointerException on the server. I am using the latest nightly build of the server.
Caused by: java.lang.NullPointerException: Cannot invoke "org.keycloak.models.UserSessionModel.getUser()" because "userSession" is null
The request that is failing is http://localhost:8180/admin/realms/test/localization/en.
500 Internal Server Error
@agagancarczyk Maybe try this with the latest nightly and see if you see this too?
|
@ssilvert I've also been seeing that error locally in other places, it is related how things are proxied during development. It should work if you do a full production build and test against that. Unfortunately, this also makes it impossible to run the Cypress tests on some suites against the development server. I think we should unify the dev server and the Keycloak server, so that the Keycloak server always is responsible for serving the front-end, even during development. I've started #27311 as a thought experiment on how to accomplish this. |
3afd4e1 to
45fcbac
Compare
|
@agagancarczyk @jonkoops OK, I was able to run the code by doing a full build and scenario 1 is fixed. I am still seeing scenario 2 from the issue. Agi, note that I updated the steps for scenario 2 as I was unclear in my original post. I also added scenario 3, which is another related problem. See the issue. |
@jonkoops That would be amazing if you can pull it off. It would also solve some other problems I've seen such as changes to message bundles that are not being reflected in dev mode. |
|
I'll try to put some time into it when we're done with the PatternFly migration 👍 |
@ssilvert scenario 2 has also been fixed. Can you try again? I pushed a fix yesterday. Maybe you are expecting something else? I'll take a look at scenario 3. |
5c80ea7 to
f9d6f10
Compare
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
Signed-off-by: Agnieszka Gancarczyk <agancarc@redhat.com>
f9d6f10 to
c2d4978
Compare
|
Closing this PR as it's old in favour of #28899 |
Closes #27837