8000 use context for adminClient by edewit · Pull Request #28693 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

use context for adminClient - #28693

Merged
edewit merged 3 commits into
keycloak:mainfrom
edewit:use-provider
May 8, 2024
Merged

use context for adminClient#28693
edewit merged 3 commits into
keycloak:mainfrom
edewit:use-provider

Conversation

@edewit
@edewit edewit commented Apr 13, 2024
Copy link
Copy Markdown
Contributor

Now we can reuse the components as we can use the adminClient from the context

Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

@edewit
edewit force-pushed the use-provider branch 7 times, most recently from 69a96df to 42150f2 Compare April 15, 2024 10:45
This was referenced Apr 15, 2024
Closed
Closed
@keycloak-github-bot
keycloak-github-bot Bot commented Apr 15, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithIntermediateRevocationListFromHttp

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginFailedWithInvalidSignatureCRL

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginWithMultipleRevocationLists

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithEmptyRevocationListFromFile

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

org.keycloak.testsuite.x509.X509BrowserCRLTest#loginSuccessWithEmptyRevocationListFromHttp

Keycloak CI - FIPS IT (non-strict)

java.lang.RuntimeException: Could not create statement
	at org.jboss.arquillian.junit.Arquillian.methodBlock(Arquillian.java:307)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 15, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@edewit
edewit marked this pull request as ready for review April 15, 2024 12:16
@edewit
edewit requested a review from a team as a code owner April 15, 2024 12:16
@edewit edewit self-assigned this Apr 15, 2024
@edewit
edewit force-pushed the use-provider branch 3 times, most recently from f0f1048 to df1c75a Compare April 18, 2024 13:43
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 18, 2024
Closed
@edewit
edewit force-pushed the use-provider branch 3 times, most recently from cbf928e to 658c130 Compare April 19, 2024 13:02
This was referenced Apr 19, 2024
Closed
Closed
@edewit
edewit force-pushed the use-provider branch 4 times, most recently from d27f42e to 1a454f8 Compare April 23, 2024 06:57
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 23, 2024
Closed
@edewit
edewit force-pushed the use-provider branch 2 times, most recently from 1e733d6 to 3f2588b Compare May 6, 2024 12:03
@edewit
edewit requested a review from jonkoops May 6, 2024 12:03
This was referenced May 6, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request May 7, 2024
Closed
edewit added 2 commits May 7, 2024 15:36
@edewit
use context for adminClient
109b3e6 
Now we can reuse the components as we can use the adminClient from the context

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@edewit
split environment into base, admin and account
b38ea98 
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
@edewit
edewit force-pushed the use-provider branch 5 times, most recently from 39714ee to c7a868c Compare May 8, 2024 05:55
@edewit
added type to useEnvironment
3db539f 
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
agagancarczyk
agagancarczyk approved these changes May 8, 2024
View reviewed changes
@agagancarczyk agagancarczyk left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@edewit
edewit merged commit e28aa90 into keycloak:main May 8, 2024
@edewit
edewit deleted the use-provider branch May 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonkoops jonkoops Awaiting requested review from jonkoops
3 more reviewers
@hmlnarik hmlnarik hmlnarik left review comments
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@agagancarczyk agagancarczyk agagancarczyk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@edewit edewit

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edewit @hmlnarik @jonkoops @agagancarczyk
0