8000 remove search box for child groups as API doesn't support by edewit · Pull Request #28835 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

remove search box for child groups as API doesn't support #28835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
edewit wants to merge 2 commits into from
Closed

remove search box for child groups as API doesn't support #28835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f67a30
remove search box for child groups as API doesn't support
edewit Apr 17, 2024
2f99ea7
removed test
edewit Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions js/apps/admin-ui/cypress/e2e/group_test.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,42 +144,6 @@ describe("Group test", () => {
});
});

describe("Search group under current group", () => {
before(async () => {
const createdGroups = await adminClient.createSubGroups(predefinedGroups);
await Promise.all([
range(5).map((index) => {
adminClient.addUserToGroup(
users[index].id!,
createdGroups[index % 3].id,
);
}),
adminClient.createUser({ username: "new", enabled: true }),
]);
});

it("Search child group in group", () => {
groupPage
.goToGroupChildGroupsTab(predefinedGroups[0])
.searchGroup(predefinedGroups[1])
.assertGroupItemExist(predefinedGroups[1], true);
});

it("Search non existing child group in group", () => {
groupPage
.goToGroupChildGroupsTab(predefinedGroups[0])
.searchGroup("non-existent-sub-group")
.assertNoSearchResultsMessageExist(true);
});

it("Empty search in group", () => {
groupPage
.goToGroupChildGroupsTab(predefinedGroups[0])
.searchGroup(" ")
.assertNoSearchResultsMessageExist(true);
});
});

describe("Group Actions", () => {
const groupNameDeleteHeaderAction = "group_test_delete_header_action";

Expand Down
32 changes: 17 additions & 15 deletions js/apps/admin-ui/src/groups/GroupTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,21 +122,23 @@ export const GroupTable = ({ refresh: viewRefresh }: GroupTableProps) => {
isSearching={!!search}
toolbarItem={
<>
<ToolbarItem>
<SearchInput
data-testid="group-search"
placeholder={t("filterGroups")}
value={search}
value) => {
setSearch(value);
}}
>
=> {
setSearch("");
refresh();
}}
/>
</ToolbarItem>
{!id && (
<ToolbarItem>
<SearchInput
data-testid="group-search"
placeholder={t("filterGroups")}
value={search}
value) => {
setSearch(value);
}}
>
5850 => {
setSearch("");
refresh();
}}
/>
</ToolbarItem>
)}
<GroupToolbar
toggleCreate={toggleCreateOpen}
toggleDelete={toggleShowDelete}
Expand Down
0