8000 28818 - Reintroduce search by name for subgroups by sguilhen · Pull Request #29011 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

28818 - Reintroduce search by name for subgroups - #29011

Merged
pedroigor merged 1 commit into
keycloak:mainfrom
sguilhen:28818-child-groups-filter
Apr 25, 2024
Merged

28818 - Reintroduce search by name for subgroups#29011
pedroigor merged 1 commit into
keycloak:mainfrom
sguilhen:28818-child-groups-filter

Conversation

@sguilhen
@sguilhen sguilhen commented Apr 23, 2024
Copy link
Copy Markdown
Contributor

Closes #28818

@sguilhen
sguilhen requested review from a team as code owners April 23, 2024 12:31
@sguilhen
28818 - Reintroduce search by name for subgroups
7fb3153 
Closes keycloak#28818

Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
@sguilhen
sguilhen force-pushed the 28818-child-groups-filter branch from 192fc2a to 7fb3153 Compare April 23, 2024 12:54
This was referenced Apr 23, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 23, 2024
Closed
Closed
Closed
@keycloak-github-bot
keycloak-github-bot Bot commented Apr 23, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.SessionTimeoutsTest#testOfflineUserClientMaxLifespanSmallerThanSession

Keycloak CI - Store Model Tests

java.lang.AssertionError: expected null, but was:<org.keycloak.models.sessions.infinispan.UserSessionAdapter@a17df6b2>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotNull(Assert.java:756)
	at org.junit.Assert.assertNull(Assert.java:738)
	at org.junit.Assert.assertNull(Assert.java:748)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 23, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@pedroigor
pedroigor commented Apr 23, 2024
Copy link
Copy Markdown
Contributor

@edewit Does it look good to you?

@edewit
edewit commented Apr 25, 2024
Copy link
Copy Markdown
Contributor

yep 👍

@edewit edewit mentioned this pull request Apr 25, 2024
Closed
@pedroigor
pedroigor merged commit 8fa2890 into keycloak:main Apr 25, 2024
@sguilhen
sguilhen deleted the 28818-child-groups-filter branch April 26, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edewit edewit edewit approved these changes
@pedroigor pedroigor pedroigor approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Child groups filtering returns all groups

3 participants

@sguilhen @pedroigor @edewit
0