8000 Cleanup of adapter pages by douglaspalmer · Pull Request #30890 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Cleanup of adapter pages - #30890

Merged
mposolda merged 1 commit into
keycloak:mainfrom
douglaspalmer:30870
Jun 27, 2024
Merged

Cleanup of adapter pages#30890
mposolda merged 1 commit into
keycloak:mainfrom
douglaspalmer:30870

Conversation

@douglaspalmer
@douglaspalmer douglaspalmer commented Jun 27, 2024
Copy link
Copy Markdown
Contributor

Closes #30870

@douglaspalmer
douglaspalmer requested review from a team as code owners June 27, 2024 14:55
@mposolda
mposolda commented Jun 27, 2024
Copy link
Copy Markdown
Contributor

@douglaspalmer It seems there are bunch of other pages, which can be cleaned? From quickly looking, seems like all those need to be kept, but rest can be probably cleaned:

AdapterLogoutPage
AppServerContextRoot
BadAssertionSalesPostSig
BadClientSalesPostSigServlet
BadRealmSalesPostSigServlet
DifferentCookieNameServlet
EcpSP
Employee* (all employee pages are used by SAML tests)
InputPortal
MissingAssertionSig
Multitenant1Saml
Multitenant2Saml
Sales* (all sales pages are used by SAML tests)
SAMLServlet

@mposolda mposolda self-assigned this Jun 27, 2024
@douglaspalmer
Cleanup of adapter pages
689cfcb 
Closes keycloak#30870

Signed-off-by: Douglas Palmer <dpalmer@redhat.com>
This was referenced Jun 27, 2024
Closed
Merged
@mposolda
mposolda merged commit 220f32a into keycloak:main Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes

Assignees

@mposolda mposolda

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cleanup of adapter pages

2 participants

@douglaspalmer @mposolda
0