8000 Revert "Fixes the auth url for account and admin" by hmlnarik · Pull Request #30117 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Revert "Fixes the auth url for account and admin" - #30117

Merged
hmlnarik merged 1 commit into
mainfrom
revert-29956-revert-29932
Jun 4, 2024
Merged

Revert "Fixes the auth url for account and admin"#30117
hmlnarik merged 1 commit into
mainfrom
revert-29956-revert-29932

Conversation

@hmlnarik
@hmlnarik hmlnarik commented Jun 4, 2024
Copy link
Copy Markdown
Contributor

Reverts #29956

@hmlnarik
hmlnarik requested a review from a team as a code owner June 4, 2024 07:08
@hmlnarik
hmlnarik enabled auto-merge (rebase) June 4, 2024 07:19
@hmlnarik
hmlnarik merged commit e5123ea into main Jun 4, 2024
@hmlnarik
hmlnarik deleted the revert-29956-revert-29932 branch June 4, 2024 07:56
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Jun 4, 2024
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Jun 4, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, 8000 please review

@keycloak-github-bot
keycloak-github-bot Bot commented Jun 4, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: expected:<Invalid authenticator code.> but was:<null>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edewit edewit edewit approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@jonkoops jonkoops jonkoops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmlnarik @edewit @jonkoops
0