8000 Add getter-methods to OAuth2GrantType.Context by Captain-P-Goldfish · Pull Request #31077 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Add getter-methods to OAuth2GrantType.Context - #31077

Merged
mposolda merged 2 commits into
keycloak:mainfrom
Captain-P-Goldfish:getter-oauth2-context
Jul 11, 2024
Merged

mposolda merged 2 commits into
keycloak:mainfrom
Captain-P-Goldfish:getter-oauth2-context

Conversation

@Captain-P-Goldfish
@Captain-P-Goldfish Captain-P-Goldfish commented Jul 5, 2024 •
Copy link
Copy Markdown
Contributor

fixes #31076

EDIT:
I haven't added a getter-method for the DPoP object to prevent a conflict with #29967

8000
@Captain-P-Goldfish
Captain-P-Goldfish requested a review from a team as a code owner July 5, 2024 10:55
fixes keycloak#31076

Signed-off-by: Pascal Knüppel <pascal.knueppel@governikus.de>
@ahus1
ahus1 commented Jul 8, 2024
Copy link
Copy Markdown
Member

@Captain-P-Goldfish - thank you for this PR. There is no need to rebase your PR unless a maintainer ask you for this, or a conflict appears in your PR.

I don't know if you have discussed this change already with someone from the @keycloak/core-clients team. I'd assume they would be the ones to review it.

@Captain-P-Goldfish
Copy link
Copy Markdown
Contributor Author

No I haven't discussed it with any of the maintainers. It is just that we need an adjusted workflow and I am currently trying to add this workflow into keycloak by using its superb externsibility possiblities. But I got stuck on several points and I added a few PullRequests for each of these problems.
Is there a good way to accelerate the review process by discussing it somewhere, or do I just have to wait patiently?

@ahus1
ahus1 commented Jul 9, 2024
Copy link
Copy Markdown
Member

When the changes you did, it seems that those are related to OIDC. There is an Keycloak OIDC special interest group (SIG). You can discuss your ideas there and you'll receive feedback from both OIDC experts and Keycloak maintainers.
See https://github.com/keycloak/kc-sig-fapi for details. At the end of the page, you find the communication channels. IMHO the slack channel mentioned there is where I would recommend to start.

For more general enhancements, an email to the Keycloak developer mailing list helps.

@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Captain-P-Goldfish Adding getters make sense. Thanks for this PR

@mposolda
mposolda merged commit b005625 into keycloak:main Jul 11, 2024
stianst pushed a commit to stianst/keycloak that referenced this pull request Jul 25, 2024
closes keycloak#31076

Signed-off-by: Pascal Knüppel <pascal.knueppel@governikus.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Oauth2GrantType.Context requires getter-methods

3 participants

0