Repository navigation
Added field to the RealmImport spec to replace environment variables within the realm import - #31232
Merged
Merged
Conversation
…within the realm import Closes keycloak#26470 Signed-off-by: stustison <scott.tustison@gmail.com>
…within the realm import Closes keycloak#26470 Signed-off-by: stustison <scott.tustison@gmail.com>
closes: keycloak#26470 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
mabartos
reviewed
Jul 24, 2024
Member
There was a problem hiding this comment.
@stustison @shawkins Looks very good! Just one nitpick.
vmuzikar
reviewed
Jul 25, 2024
Contributor
There was a problem hiding this comment.
@stustison @shawkins Thank you both for the changes! LGTM, I'd just suggest to add some short example to the RealmImport CR docs and maybe a mention to release notes too.
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Contributor
Author
Added the docs. |
8000
mabartos
reviewed
Jul 26, 2024
Member
There was a problem hiding this comment.
Some nitpicks -> but mainly the 'on' vs. 'only'
Co-authored-by: Martin Bartoš <mabartos@redhat.com> Signed-off-by: Steven Hawkins <shawkins@redhat.com>
Co-authored-by: Martin Bartoš <mabartos@redhat.com> Signed-off-by: Steven Hawkins <shawkins@redhat.com>
Contributor
Author
|
@mabartos thanks for the review, those suggestions have been added. |
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26470
Replaces #26471