8000 Update the welcome page to create a temporary admin user by mabartos · Pull Request #32283 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Update the welcome page to create a temporary admin user - #32283

Merged
jonkoops merged 1 commit into
keycloak:mainfrom
mabartos:KC-30010
Sep 3, 2024
Merged

Update the welcome page to create a temporary admin user#32283
jonkoops merged 1 commit into
keycloak:mainfrom
mabartos:KC-30010

Conversation

@mabartos
@mabartos mabartos commented Aug 20, 2024 •
edited
Loading
Copy link
Copy Markdown
Member

Closes #30010

image

@mabartos
mabartos marked this pull request as ready for review August 20, 2024 15:36
@mabartos
mabartos requested review from a team as code owners August 20, 2024 15:36
@mabartos
mabartos requested a review from vmuzikar August 20, 2024 15:36
@mabartos
mabartos marked this pull request as draft August 20, 2024 16:26
vmuzikar
vmuzikar previously approved these changes Aug 21, 2024
View reviewed changes
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the Cloud Native perspective. Thanks @mabartos

@mabartos
mabartos commented Aug 21, 2024
Copy link
Copy Markdown
Member Author

Not sure what might be the cause of these failures as I wasn't able to reproduce it. Rebased

@mabartos
mabartos marked this pull request as ready for review August 27, 2024 16:13
@mabartos
mabartos requested review from a team as code owners August 27, 2024 16:13
vmuzikar
vmuzikar previously approved these changes Aug 27, 2024
View reviewed changes
@keycloak-github-bot
keycloak-github-bot Bot commented Aug 27, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.kerberos.KerberosStandaloneCrossRealmTrustTest#test03SpnegoLoginWithCorrectKerberosPrincipalRealm

Keycloak CI - Base IT (5)

org.openqa.selenium.TimeoutException: 
java.net.SocketTimeoutException: Read timed out
Build info: version: '4.21.0', revision: '79ed462ef4'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1025-azure', java.version: '21.0.4'
Driver info: driver.version: HtmlUnitDriver
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Aug 27, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@mabartos
mabartos commented Aug 27, 2024
Copy link
Copy Markdown
Member Author

@keycloak/ui-maintainers Could you please check it? Thanks!

@mabartos
mabartos commented Aug 29, 2024
Copy link
Copy Markdown
Member Author

@ssilvert @edewit Hi, are these changes okay to you? Thanks

@mabartos
mabartos requested a review from edewit August 29, 2024 15:22
ssilvert
ssilvert previously requested changes Aug 29, 2024
View reviewed changes
Comment thread themes/src/main/resources/theme/keycloak/welcome/index.ftl Resolved
@mabartos @ssilvert
Update the welcome page to create a temporary admin user
a625324 
Closes keycloak#30010

Co-authored-by: Stan Silvert <ssilvert@redhat.com>
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Aug 30, 2024
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Aug 30, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Aug 30, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.ResidentKeyRegisterTest#residentKeyRequiredWrong

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=0057ca6e-d373-46e5-8572-527eeb921569&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

This was referenced Aug 30, 2024
Closed
Closed
@keycloak-github-bot
keycloak-github-bot Bot commented Aug 30, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.ResidentKeyRegisterTest#residentKeyRequiredWrong

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=0057ca6e-d373-46e5-8572-527eeb921569&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.BruteForceTest#testResetPassword

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

org.keycloak.testsuite.forms.ResetPasswordTest#resetPasswordWithSpacesInUsername

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected LoginPasswordResetPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=ceecf4dd-24e2-4f1e-a5e4-56292e59ac92&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.ResetPasswordTest#changeEmailAddressAfterSendingEmail

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected LoginPasswordResetPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=470d833d-77da-48bb-9341-b478a0f9b159&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

keycloak-github-bot[bot] 8BD0
keycloak-github-bot Bot reviewed Aug 30, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@mabartos
mabartos commented Aug 30, 2024
Copy link
Copy Markdown
Member Author

@ssilvert @vmuzikar Could you please review it again? Thanks!

@mabartos
mabartos requested review from ssilvert and vmuzikar August 30, 2024 12:57
vmuzikar
vmuzikar approved these changes Aug 30, 2024
View reviewed changes
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM!

 10000

jonkoops
jonkoops approved these changes Sep 2, 2024
View reviewed changes
@jonkoops jonkoops left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabartos
mabartos commented Sep 3, 2024
Copy link
Copy Markdown
Member Author

Thanks for the reviews!

@vmuzikar I think it should be ready to merge.

@jonkoops
jonkoops dismissed ssilvert’s stale review September 3, 2024 07:43

Changes have been applied

@jonkoops
jonkoops merged commit db7694e into keycloak:main Sep 3, 2024
@vilmosnagy vilmosnagy mentioned this pull request Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
@edewit edewit Awaiting requested review from edewit
@ssilvert ssilvert Awaiting requested review from ssilvert
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@jonkoops jonkoops jonkoops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the welcome page to create a temporary admin user

4 participants

@mabartos @ssilvert @jonkoops @vmuzikar
0