8000 Add the nonce attribute when the client session context is recreated (25) by rmartinc · Pull Request #33509 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Add the nonce attribute when the client session context is recreated (25) - #33509

Merged
mposolda merged 2 commits into
keycloak:release/25.0from
rmartinc:backport-33422-25.0
Oct 3, 2024
Merged

Add the nonce attribute when the client session context is recreated (25)#33509
mposolda merged 2 commits into
keycloak:release/25.0from
rmartinc:backport-33422-25.0

Conversation

@rmartinc
@rmartinc rmartinc commented Oct 3, 2024
Copy link
Copy Markdown
Contributor

Closes #33355

PR: #33422
Commit: 6e471a8
PR branch: backport-33422-25.0
Target branch: https://github.com/keycloak/keycloak/tree/release/25.0

Signed-off-by: rmartinc rmartinc@redhat.com
Co-authored-by: Tomas Kralik tomas.kralik@pbktechnology.cz
(cherry picked from commit 6e471a8)

@rmartinc Tomas Kralik
Add the nonce attribute when the client session context is recreated (k…
9e8d17b 
…eycloak#33422)

Closes keycloak#33355

Signed-off-by: rmartinc <rmartinc@redhat.com>
Co-authored-by: Tomas Kralik <tomas.kralik@pbktechnology.cz>
(cherry picked from commit 6e471a8)
@rmartinc
rmartinc requested review from a team as code owners October 3, 2024 07:38
@mposolda mposolda self-assigned this Oct 3, 2024
@rmartinc
rmartinc commented Oct 3, 2024 •
edited
Loading
Copy link
Copy Markdown
Contributor Author

@mposolda The Base IT 6 is failing because there is a race that was fixed upstream: 42cde0c (just needed the changes in the class saml test classes, it's a hang, that's why it's finally cancelled). Do you want me to backport the changes? Here or another PR?

@sguilhen @rmartinc @jonkoops
Fix various issues holding up CI (keycloak#33086)
927f77f 
- Disables the remote operator tests, which will have to be fixed later.
- Fixes the action expired error which occurs when accessing regular registration page with Organizations enabled.
- Fixes a race condition in the test suite causing sporadic failures.

Closes keycloak#33064

Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
Signed-off-by: rmartinc <rmartinc@redhat.com>
Signed-off-by: Jon Koops <jonkoops@gmail.com>
Co-authored-by: rmartinc <rmartinc@redhat.com>
Co-authored-by: Jon Koops <jonkoops@gmail.com>
@rmartinc
rmartinc commented Oct 3, 2024
Copy link
Copy Markdown
Contributor Author

I have backported that fix as a second commit removing the other things for org. Just the two saml test classes.

@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Oct 3, 2024
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 3, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 3, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.oidc.AuthenticationMethodReferenceTest#testAmrPastMaxAge

Keycloak CI - Base IT (6)

java.lang.AssertionError: expected:<200> but was:<400>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

Report flaky test

org.keycloak.testsuite.forms.RecoveryAuthnCodesAuthenticatorTest#test03AuthenticateRecoveryAuthnCodes

Keycloak CI - Forms IT (firefox)

org.openqa.selenium.TimeoutException: 
Navigation timed out after 10000 ms
Build info: version: '4.21.0', revision: '79ed462ef4'
System info: os.name: 'Linux', os.arch: 'amd64', os.version: '6.8.0-1014-azure', java.version: '21.0.4'
Driver info: org.openqa.selenium.firefox.FirefoxDriver
...

Report flaky test

@mposolda
mposolda merged commit 0820633 into keycloak:release/25.0 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@jonkoops jonkoops jonkoops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rmartinc @jonkoops @mposolda @sguilhen
0